Fail to seek data from yiiActiveForm('data') #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix if the parsing method failed to seek settings data from `yiiActiveForm('data')`.
Will use default CSS classes and seek settings only if the object is not undefined.
minifying edited JS
|
Ah btw, I am using Yii version 2.0.28 as per I create this PR. |
|
Maybe @wbraganca can take a look for this. |
|
Hello @wbraganca and @agungsijawir, |
|
Hello @AnniG Thanks for reaching me out. I am curious that my PR still not merged nor get any feedback. It looks like the author is away. If somehow my patch works for you, thank you. |
StitchUA
added a commit
to StitchUA/yii2-dynamicform
that referenced
this pull request
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes script failed to seek settings data from
yiiActiveForm('data'), thus will render errors on forms.This patch fixes the issue by checking if
typeof yiiActiveFormDatais not undefined, allow seeking from data, otherwise use default Yii error/success, CSS Class.