Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix null description error #51

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix null description error #51

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a25c3c
Fix null description error
Jul 21, 2017
6ebf2c5
use strict comparison with undefined
Jul 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/jquery.stepy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@
if (this.stepyOptions.description) {
var description = methods._description.call(this, step);

if (description.length) {
if (description != null && description.length) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you need to use description !== null to compare strict with types. 😄

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valid point. It was also undefined, not null so I changed that as well.

head.append(description);
}
}
Expand Down