Skip to content
This repository has been archived by the owner on Mar 28, 2024. It is now read-only.

Conformance test for SDX (tested by ClimateCamp) #94

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Conformance test for SDX (tested by ClimateCamp) #94

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a83c927
Create result-sdx-001.json
19-SD Dec 12, 2023
fd09911
Merge branch 'wbcsd:main' into main
19-SD Dec 13, 2023
621203e
Update version and website in solution.json
19-SD Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions catalog/conformance-tests/result-sdx-001.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"tested_solution": {
"solution_id": "sdx",
"version": "1.0.0"
Copy link
Contributor

@prasadt1 prasadt1 Dec 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@19-SD - Thanks for your PR. There is one issue though - the existing version of the SDX solution in the catalog is 0.8.0 but here it says 1.0.0. Please verify!

Cc: @raimundo-henriques

Copy link
Contributor Author

@19-SD 19-SD Dec 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prasadt1 Nice catch! Should be 1.0.0. Do we update existing directory name (sdx/0.8.0) and solution file, just the solution file or create a new directory with a new file?

I assume we will keep updating this solution version over time while remaining 'conformant'? Even though the conformance tests at some point will then refer to previous versions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@19-SD - Thanks for your reply. Here are 2 options we can do as PRs -

  1. If SAP is Ok with keeping only the latest version i.e. v 1.0.0 for the SDX Solution, then please add a commit to update existing directory name (sdx/0.8.0) and solution file to v 1.0.0, once done we will review the updated PR and merge it .

  2. If SAP wants to keep both the versions (0.8.0 and 1.0.0), then either we or SAP can submit a new PR (or a commit in this PR), to add a new solution.json file with v 1.0.0 details. Unfortunately we haven't optimized the PACT Catalog yet to maintain version hierarchy within same Solution page, kindly note this is still a beta version and these optimisations and features are considered in the stable release when we do it. Till then if an Org has multiple versions of the Same Solution, then they will be displayed as n separate Solutions (with n different versions) on the catalog.

Please let us know what option you prefer, and accordingly submit a commit / PR or let us know we can do so as well.

Thanks
Prasad

Cc: @raimundo-henriques @zeitgeist

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prasadt1 We go for first option, solution file has been updated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@19-SD - Thanks for your comment and updates. I merged the PR.

Cc: @raimundo-henriques @zeitgeist

},
"tested_by": {
"solution_id": "climatecamp",
"version": "2.0.0"
},
"test_result": "passed",
"test_date": "2023-12-11T09:00:00Z",
"pathfinder_version": "2.0.1",
"extensions_tested": []
}
Loading