This repository has been archived by the owner on Mar 28, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 34
Conformance test for SDX (tested by ClimateCamp) #94
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| { | ||
| "tested_solution": { | ||
| "solution_id": "sdx", | ||
| "version": "1.0.0" | ||
| }, | ||
| "tested_by": { | ||
| "solution_id": "climatecamp", | ||
| "version": "2.0.0" | ||
| }, | ||
| "test_result": "passed", | ||
| "test_date": "2023-12-11T09:00:00Z", | ||
| "pathfinder_version": "2.0.1", | ||
| "extensions_tested": [] | ||
| } | ||
4 changes: 2 additions & 2 deletions
4
catalog/solutions/sdx/0.8.0/solution.json → catalog/solutions/sdx/1.0.0/solution.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@19-SD - Thanks for your PR. There is one issue though - the existing version of the SDX solution in the catalog is 0.8.0 but here it says 1.0.0. Please verify!
Cc: @raimundo-henriques
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prasadt1 Nice catch! Should be 1.0.0. Do we update existing directory name (sdx/0.8.0) and solution file, just the solution file or create a new directory with a new file?
I assume we will keep updating this solution version over time while remaining 'conformant'? Even though the conformance tests at some point will then refer to previous versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@19-SD - Thanks for your reply. Here are 2 options we can do as PRs -
If SAP is Ok with keeping only the latest version i.e. v 1.0.0 for the SDX Solution, then please add a commit to update existing directory name (sdx/0.8.0) and solution file to v 1.0.0, once done we will review the updated PR and merge it .
If SAP wants to keep both the versions (0.8.0 and 1.0.0), then either we or SAP can submit a new PR (or a commit in this PR), to add a new solution.json file with v 1.0.0 details. Unfortunately we haven't optimized the PACT Catalog yet to maintain version hierarchy within same Solution page, kindly note this is still a beta version and these optimisations and features are considered in the stable release when we do it. Till then if an Org has multiple versions of the Same Solution, then they will be displayed as n separate Solutions (with n different versions) on the catalog.
Please let us know what option you prefer, and accordingly submit a commit / PR or let us know we can do so as well.
Thanks
Prasad
Cc: @raimundo-henriques @zeitgeist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prasadt1 We go for first option, solution file has been updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@19-SD - Thanks for your comment and updates. I merged the PR.
Cc: @raimundo-henriques @zeitgeist