This repository has been archived by the owner on Mar 28, 2024. It is now read-only.
feat: carbmee test result #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KushKan0402 is attempting to deploy a commit to the wbcsd Team on Vercel. A member of the Team first needs to authorize it. |
raimundo-henriques
suggested changes
Dec 11, 2023
There was a problem hiding this comment.
Thank you for the PR, @KushKan0402,
The solutions' versions must have three digits (to conform with semver).
Please see my inline suggestions (and correct them accordingly).
Please note also that the solution_id and the version must remain consistent once you add your solutions to the catalog.
Thank you!
@prasadt1
Co-authored-by: Raimundo Henriques <[email protected]>
Co-authored-by: Raimundo Henriques <[email protected]>
|
@KushKan0402 - can you pelase also add the solution json for your solution? Thanks! Refer this resource. |
|
Hi Prasad,
Thanks for the update. I will add the solution.json as per the requirements and update my pull request.
Regards,
Kushagra
…________________________________
From: PRASAD TILLOO ***@***.***>
Sent: Tuesday, December 12, 2023 7:03 PM
To: wbcsd/pact-catalog ***@***.***>
Cc: Kushagra Kanodia ***@***.***>; Mention ***@***.***>
Subject: Re: [wbcsd/pact-catalog] feat: carbmee test result (PR #92)
@KushKan0402<https://github.com/KushKan0402> - can you pelase also add the solution json for your solution? Thanks! Refer this<https://github.com/wbcsd/pact-catalog/blob/main/CONTRIB_SOLUTION.md> resource.
Cc: @raimundo-henriques<https://github.com/raimundo-henriques>
—
Reply to this email directly, view it on GitHub<#92 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BCMGLQJMYT7HX7TGAM3MV23YJA2Y3AVCNFSM6AAAAABAPLYVRKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJRHAYTONJQGU>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
@KushKan0402 - Thanks for your response. Can you kindly submit this sooner as CarbMee and Misrosoft are blocked because of this pending solution submission? Appreciate your quick support here. |
|
Hi Prasad,
I recently updated the PR and it still shows failing. Can u recommend me what issues need to be addressed.
Regards,
Kushagra
…________________________________
From: PRASAD TILLOO ***@***.***>
Sent: Wednesday, December 13, 2023 5:43 PM
To: wbcsd/pact-catalog ***@***.***>
Cc: Kushagra Kanodia ***@***.***>; Mention ***@***.***>
Subject: Re: [wbcsd/pact-catalog] feat: carbmee test result (PR #92)
@KushKan0402<https://github.com/KushKan0402> - Thanks for your response. Can you kindly submit this sooner as CarbMee and Misrosoft are blocked because of this pending solution submission?
Appreciate your quick support here.
Cc: @raimundo-henriques<https://github.com/raimundo-henriques>
—
Reply to this email directly, view it on GitHub<#92 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BCMGLQNSHJEVL4RF4N2H3ZLYJF2FZAVCNFSM6AAAAABAPLYVRKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJTGU4DCMBXGM>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
prasadt1
approved these changes
Dec 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.