Skip to content
This repository has been archived by the owner on Mar 28, 2024. It is now read-only.

feat: Result of conformance testing by Hitachi #48

Merged
merged 3 commits into from
Jul 26, 2023

Conversation

mill6-plat6aux
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Jul 14, 2023

Someone is attempting to deploy a commit to the wbcsd Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Jul 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pact-catalog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2023 8:04am

Copy link
Contributor

@zeitgeist zeitgeist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR. Please find a Q inline.

},
"test_result": "passed",
"test_date": "2023-05-26T06:52:00Z",
"pathfinder_version": "1.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"pathfinder_version": "1.0.0"
"pathfinder_version": "1.0.1"

Thank you for creating this PR, @mill6-plat6aux.

Your other conformance testing results are mentioning 1.0.1. Did you perform the conformance testing against Pathfinder Tech Specs Version 1.0.0 or 1.0.1?

Copy link
Contributor Author

@mill6-plat6aux mill6-plat6aux Jul 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you said, the pathfinder_version for the past two tests was 1.0.1, which was an incorrect 1.0.0.
Therefore, the description of the test by Hitachi is correct. Conversely, I would like to correct the pathfinder_version of the test by zeroboard and boost technologies to 1.0.0, should I correct the file and send the pull request again?

Copy link
Contributor

@prasadt1 prasadt1 Jul 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mill6-plat6aux - answering on behalf of @zeitgeist . Yes please submit either 1 PR with both the files changed for boost and zeroboard OR
individual PRs for Zeroboard and boost.

Either option works for us!
Thanks for your help!

@prasadt1 prasadt1 merged commit fb2aa83 into wbcsd:main Jul 26, 2023
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants