-
Notifications
You must be signed in to change notification settings - Fork 34
feat: Result of conformance testing by Hitachi #48
Conversation
Someone is attempting to deploy a commit to the wbcsd Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR. Please find a Q inline.
}, | ||
"test_result": "passed", | ||
"test_date": "2023-05-26T06:52:00Z", | ||
"pathfinder_version": "1.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"pathfinder_version": "1.0.0" | |
"pathfinder_version": "1.0.1" |
Thank you for creating this PR, @mill6-plat6aux.
Your other conformance testing results are mentioning 1.0.1
. Did you perform the conformance testing against Pathfinder Tech Specs Version 1.0.0
or 1.0.1
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you said, the pathfinder_version
for the past two tests was 1.0.1
, which was an incorrect 1.0.0
.
Therefore, the description of the test by Hitachi is correct. Conversely, I would like to correct the pathfinder_version
of the test by zeroboard and boost technologies to 1.0.0
, should I correct the file and send the pull request again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mill6-plat6aux - answering on behalf of @zeitgeist . Yes please submit either 1 PR with both the files changed for boost and zeroboard OR
individual PRs for Zeroboard and boost.
Either option works for us!
Thanks for your help!
No description provided.