Add Hitachi EcoAssist solution and conformance results #46
Conversation
Added Hitachi user , EcoAssist-Pro/LCA solution and conformance test results with NRI and Zeroboard. Please pull them, thank you.
|
@masashi-amano is attempting to deploy a commit to the wbcsd Team on Vercel. A member of the Team first needs to authorize it. |
change tested_solution/version format 02_00g_P to 02.00g.P
change tested_solution/version format 02_00g_P to 02.00g.P
change version format 02_00g_P to 02.00g.P
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Dear @masashi-amano ,
Thank you very much for your PR!
Before being able to push your solution to the catalog, we need to discuss a couple of things.
One concerns the format of your solution's version, as it does not correspond to the format the catalog is ready to receive as of right now.
The other concerns the "logo" field in the "hitachi.json" file.
Please see the inline comments.
Thank you,
@prasadt1
| { | ||
| "id": "ecoassist-prolca", | ||
| "name": "EcoAssist-Pro/LCA", | ||
| "version": "02.00g.P", |
There was a problem hiding this comment.
I'm sorry to ask, but is this the actual format of your solution's version, or might it be some sort of typo/formatting issue?
As of right now, the catalog expects versions to follow the SemVer syntax (e.g., "2.0.1"; regex: /^[0-9]\.[0-9]\.[0-9]$/). If your format is different, could you please provide some more information about it?
(This also applies to the file path.)
Thank you!
There was a problem hiding this comment.
Thank you for your advice.
The version format I presented is our format system.
Please wait shortly as we will consider whether it is possible to register in the format of "^[0-9].[0-9].[0-9]$".
We will consider the path as well.
Thank you.
There was a problem hiding this comment.
Dear @raimundo-henriques and @prasadt1,
As a result of internal consideration, the version notation for EcoAssist-Pro/LCA on PACT PR was decided to be "2.0.0".
Please confirm it.
Thank you.
| { | ||
| "tested_solution": { | ||
| "solution_id": "ecoassist-prolca", | ||
| "version": "02.00g.P" |
There was a problem hiding this comment.
(Please see inline comment on the solution.json file.)
| { | ||
| "tested_solution": { | ||
| "solution_id": "ecoassist-prolca", | ||
| "version": "02.00g.P" |
There was a problem hiding this comment.
(Please see inline comment on the solution.json file.)
catalog/users/hitachi-cslogo.zip
Outdated
There was a problem hiding this comment.
The users directory can only contain <user>.json files, so unfortunately I will need to ask you to delete this one. Please see the inline comment on the hitachi.json about the logo
catalog/users/hitachi.json
Outdated
| "name": "Hitachi, Ltd.", | ||
| "email": "", | ||
| "website": "https://www.hitachi.com/", | ||
| "logo": "Logo data is uploaded to Github. (pact-catalog/users/hitachi-cslogo.zip)" |
There was a problem hiding this comment.
The "logo" field only accepts a URL as its value. Can you please replace the current string by one containing a URL to your logo (hosted somewhere else)?
Thank you!
There was a problem hiding this comment.
In order to use our company's logo, it is mandatory to receive a usage manual according to our company's regulations, and the location of the logo file cannot be indicated as a URL.
We will also consider this internally, and depending on the case, there is a possibility that it will be registered without the logo.
Thank you.
There was a problem hiding this comment.
Dear @raimundo-henriques and @prasadt1,
As a result of our internal review, we will temporarily register without the logo. As soon as the internal procedures are completed so that the URL can be obtained, we will update solution.json that includes the URL of the logo.
Also, sorry, we can not prepare the official email for EcoAssist-Pro/LCA. However an user considering to use EcoAssist can access through a form on our official web site.
Thank you.
We changed version notation in solution.json and conformance results "02-00g_P" to "2.0.0" . Also we canceled the registration of the logo file.
There was a problem hiding this comment.
Hello again @masashi-amano,
Thank you very much for the changes!
In case you do not want to include an email and a logo, please leave these (optional) fields out completely. (Validation checks whether the string is a valid email/url and hence does not currently accept empty strings).
Please see my inline comments.
Sorry for the inconvenience and thank you!
catalog/users/hitachi.json
Outdated
| "id": "hitachi", | ||
| "kind": "solutionprovider", | ||
| "name": "Hitachi, Ltd.", | ||
| "email": "", |
There was a problem hiding this comment.
| "email": "", |
There was a problem hiding this comment.
Thank you for your advice.
I removed optional properties "email" and "logo" in users/hitachi.json .
Please confirm it.
Thank you.
catalog/users/hitachi.json
Outdated
| "name": "Hitachi, Ltd.", | ||
| "email": "", | ||
| "website": "https://www.hitachi.com/", | ||
| "logo": "" |
There was a problem hiding this comment.
| "logo": "" |
Removed optional fields email and logo.
|
Dear @raimundo-henriques , |
Added Hitachi user , EcoAssist-Pro/LCA solution and conformance test results with NRI and Zeroboard. Please pull them, thank you.