ADR-0037 proposal to replace productCategoryCpc with productClassifications #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhadley
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
LGTM! productCategoryCpc is an attribute that our community has shared lots of feedback on as of questionable relevance and importance. The decision was reached earlier this year to make it optional in v3; this proposal would be an improvement on that decision to further generalize the classification identifiers that can be provided (https://flat-dollar-c04.notion.site/productCategoryCPC-Mandatory-OR-Optional-c6963fc3aa31451ba10ef05e159de513?pvs=74)
bhadley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.