Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADR 0036 to clarify product amount #94

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ADR 0036 to clarify product amount #94

wants to merge 2 commits into from

Conversation

schuur
Copy link
Contributor

@schuur schuur commented Aug 29, 2024

@schuur schuur requested a review from bhadley August 29, 2024 14:10
@schuur schuur changed the title ADR 36 to clarify product amount clarification ADR 0036 to clarify product amount clarification Aug 29, 2024
@bhadley bhadley changed the title ADR 0036 to clarify product amount clarification ADR 0036 to clarify product amount Sep 3, 2024
bhadley
bhadley approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@bhadley bhadley left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks for catching those issues! This one is ready for working group I'd say!

@schuur schuur marked this pull request as ready for review September 3, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhadley bhadley bhadley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schuur @bhadley