Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated docstrings + bugfix pol2car #50

Merged
merged 10 commits into from
Jan 6, 2024
Merged

Updated docstrings + bugfix pol2car #50

merged 10 commits into from
Jan 6, 2024

Conversation

gotten
Copy link
Collaborator

@gotten gotten commented Jan 6, 2024

Partial update for #41 and #44.

@gotten gotten requested a review from wbalmer January 6, 2024 11:33
@gotten
Copy link
Collaborator Author

gotten commented Jan 6, 2024 •
edited
Loading

I noticed modules.rst was changed so it no longer mentions API. Feel free to update it when merging.

Edit: fixed it in the fork.

@gotten
Copy link
Collaborator Author

gotten commented Jan 6, 2024

Alright, docstrings are completeish. But can be improved.

@gotten gotten changed the title Updated docstrings for utils.py + bugfix pol2car Updated docstrings + bugfix pol2car Jan 6, 2024
@gotten gotten added bug Something isn't working documentation Improvements or additions to documentation labels Jan 6, 2024
wbalmer
wbalmer approved these changes Jan 6, 2024
View reviewed changes
Copy link
Owner

@wbalmer wbalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! this is really excellent, I had started on some docstrings locally but you've lapped my progress many times over. I'll merge this now, thank you Gilles!

@wbalmer wbalmer merged commit 704a68d into wbalmer:main Jan 6, 2024
3 checks passed
@wbalmer wbalmer added this to the Version 0.4 milestone Jan 6, 2024
@gotten gotten deleted the docs branch January 8, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbalmer wbalmer wbalmer approved these changes

Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
Version 0.4
Development

Successfully merging this pull request may close these issues.
2 participants
@gotten @wbalmer