Enhancement/14 add key to register and authentication #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ip parameter is removed from the registration process as it will no longer be necessary. Also the parameter key is added to the registration process. Then this key is also sent together with the uuid during authentication. Unit tests are fixed.
jr0me
requested changes
Aug 19, 2024
Closed
sdvendramini
force-pushed
the
enhancement/14-add-key-to-register-and-authentication
branch
4 times, most recently
from
75705fd to
d7296e4
Compare
Some functions were defined as std::function in order to be able to mock them correctly in gtest without having to define abstract classes or interfaces. This way it was possible to mock everything needed to run the log test correctly.
sdvendramini
force-pushed
the
enhancement/14-add-key-to-register-and-authentication
branch
from
d7296e4 to
99f7a47
Compare
jr0me
approved these changes
Aug 19, 2024
TomasTurina
approved these changes
Aug 19, 2024
TomasTurina
deleted the
enhancement/14-add-key-to-register-and-authentication
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
This PR aims to correct the necessary parameters to complete the registration process and test this function correctly.