Enhancement/71 remove client conditional directives from the code #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdvendramini
force-pushed
the
enhancement/71-remove-client-conditional-directives-from-the-code
branch
2 times, most recently
from
2e9b2d7 to
d949d67
Compare
sdvendramini
force-pushed
the
enhancement/71-remove-client-conditional-directives-from-the-code
branch
from
d949d67 to
6ce47bb
Compare
TomasTurina
reviewed
Aug 12, 2024
sdvendramini
force-pushed
the
enhancement/71-remove-client-conditional-directives-from-the-code
branch
from
6ce47bb to
918d3d1
Compare
TomasTurina
approved these changes
Aug 12, 2024
TomasTurina
reviewed
Aug 12, 2024
The use of the CLIENT directive is deleted and all manager logic is removed.
sdvendramini
force-pushed
the
enhancement/71-remove-client-conditional-directives-from-the-code
branch
from
918d3d1 to
7a253cc
Compare
TomasTurina
reviewed
Aug 12, 2024
sdvendramini
force-pushed
the
enhancement/71-remove-client-conditional-directives-from-the-code
branch
from
7947f35 to
22004cd
Compare
TomasTurina
approved these changes
Aug 13, 2024
TomasTurina
deleted the
enhancement/71-remove-client-conditional-directives-from-the-code
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
#71
Description
This PR adds the changes to delete the use of the CLIENT conditional directive and remove any unnecessary manager-related code used along with these directives.