Timeouts in operations with sockets #417
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
aritosteles
requested review from
TomasTurina,
jr0me,
sdvendramini and
Nicogp
aritosteles
force-pushed
the
enhancement/157-improve-error-handling
branch
4 times, most recently
from
30f920d to
83e4230
Compare
TomasTurina
reviewed
Dec 13, 2024
| @@ -18,8 +21,10 @@ namespace http_client | |||
| /// @brief Connects the socket to the given endpoints | |||
| /// @param endpoints The endpoints to connect to | |||
| /// @param ec The error code, if any occurred | |||
| virtual void Connect(const boost::asio::ip::tcp::resolver::results_type& endpoints, | |||
| boost::system::error_code& ec) = 0; | |||
| virtual void Connect(boost::asio::io_context& io_context, | |||
There was a problem hiding this comment.
Add missing parameters to function description.
TomasTurina
reviewed
Dec 13, 2024
| /// @param endpoints The endpoints to connect to | ||
| /// @param ec The error code, if any occurred | ||
| void Connect(const boost::asio::ip::tcp::resolver::results_type& endpoints, | ||
| boost::system::error_code& ec) override | ||
| void Connect(boost::asio::io_context& io_context, |
TomasTurina
reviewed
Dec 13, 2024
| @@ -27,24 +27,54 @@ namespace http_client | |||
| /// @brief Connects the socket to the given endpoints | |||
| /// @param endpoints The endpoints to connect to | |||
| /// @param ec The error code, if any occurred | |||
| void Connect(const boost::asio::ip::tcp::resolver::results_type& endpoints, | |||
| boost::system::error_code& ec) override | |||
| void Connect(boost::asio::io_context& io_context, | |||
Adds timeout to Connect() function
aritosteles
force-pushed
the
enhancement/157-improve-error-handling
branch
3 times, most recently
from
bfdaee3 to
c6db8be
Compare
HttpsSocket will be addressed in later commit.
aritosteles
force-pushed
the
enhancement/157-improve-error-handling
branch
from
c6db8be to
a6ba4f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds timeouts to socket operations that can block the process/co_routine indefinitely.