Adapt command structure to new definition #408
+135
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `getCommandFromQueue` function has been updated to parse commands according to the new definition. Additionally, the related tests have been fixed.
A function is added to validate commands, ensuring their arguments are also valid when required, and assigning the corresponding module. A map is created containing the valid commands, their associated module, and whether argument validation is needed.
The argument parsing method in the centralized configuration is updated, and the related tests are fixed.
sdvendramini
force-pushed
the
enhancement/394-adapt-command-structure-to-new-definition
branch
from
9af90e2 to
a1fc379
Compare
The mock server created with Imposter has been updated with the latest changes related to commands. Some test cases have been added.
TomasTurina
reviewed
Dec 11, 2024
| def command = [ | ||
| "document_id": generateUUIDv7(), | ||
| "action": action, | ||
| "target": ["type": "agent", "id": "agentID"], |
There was a problem hiding this comment.
What is agentID? Does it need to be manually edited?
There was a problem hiding this comment.
It's just a trivial value; it doesn't need to be edited since the mock will send all commands to the agent that made the request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to complete the necessary changes to adapt command processing to the newly defined structure received by the agent.