Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Agent's Queue Component #28

Merged
merged 31 commits into from
Aug 13, 2024
Merged

New Agent's Queue Component #28

merged 31 commits into from
Aug 13, 2024

Conversation

LucioDonda
Copy link
Member

@LucioDonda LucioDonda commented Jul 4, 2024 •
edited
Loading

Description

First implementation of the queue component for the 5.0 agent version

Issue #16

@cborla cborla linked an issue Jul 8, 2024 that may be closed by this pull request
Implement Queue Component #16
Closed
@cborla cborla marked this pull request as draft July 8, 2024 13:50
@LucioDonda LucioDonda force-pushed the 16-implement-queue-component branch 3 times, most recently from 1e7f47f to 00d2a2c Compare July 16, 2024 14:37
@LucioDonda LucioDonda force-pushed the 16-implement-queue-component branch 2 times, most recently from 7f23e17 to 8d04773 Compare July 22, 2024 21:21
LucioDonda
LucioDonda commented Jul 22, 2024
View reviewed changes
src/agent/CMakeLists.txt Outdated Show resolved Hide resolved
@LucioDonda LucioDonda force-pushed the 16-implement-queue-component branch 4 times, most recently from b518212 to 93ec454 Compare August 7, 2024 13:17
LucioDonda and others added 16 commits August 9, 2024 11:10
@LucioDonda
feat: initial commit of queue component
6ab8fca
@LucioDonda
feat: code style, test and additional methods
b710c15
@LucioDonda
feat: add corrections on maps and helper functions plus tests WIP
7f4b7ac
@cborla @LucioDonda
feat: data persistence stage for the queue module
106f528
@LucioDonda
fix: compiling with tests
330bb2e
@LucioDonda
perf: enabling polymorphism in persistence
1dc6f54
@LucioDonda
test: additional test cases and behavior correction
646dc6d
@LucioDonda
fix: all test passing
af616b9
@LucioDonda
feat: add push and pop for multiple messages
b50a805
@LucioDonda
feat: rename STATEs enum values
8224c99
@cborla @LucioDonda
feat: change sqlite library to SQLiteCpp, improvement in exceptions
778793c
@cborla @LucioDonda
fix: clean code from warning messages
2a36513
@LucioDonda
feat: timeout on push and removing filestorage
b7d28cf
@LucioDonda
feat: separing queue with header and building as library
88cdad2
@LucioDonda
fix: change to a correct use of clang-format
3567cb6
@LucioDonda
feat: unify cmakes and vcpkg usage
7ec08f9
@cborla
Copy link
Member

cborla commented Aug 13, 2024 •
edited
Loading

I think we are close to having a good version, just a few tweaks, good job. 🚀

jr0me
jr0me reviewed Aug 13, 2024
View reviewed changes
Copy link
Member

@jr0me jr0me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! I left a few comments from trying to integrate the PR into the Agent.

src/agent/queue/CMakeLists.txt Outdated Show resolved Hide resolved
src/agent/queue/CMakeLists.txt Outdated Show resolved Hide resolved
src/agent/queue/CMakeLists.txt Outdated Show resolved Hide resolved
src/agent/queue/tests/CMakeLists.txt Outdated Show resolved Hide resolved
src/agent/queue/include/queue.hpp Outdated Show resolved Hide resolved
@LucioDonda LucioDonda force-pushed the 16-implement-queue-component branch from e12a36c to 16e813a Compare August 13, 2024 15:08
@LucioDonda LucioDonda force-pushed the 16-implement-queue-component branch from 16e813a to 05591d7 Compare August 13, 2024 15:20
@LucioDonda LucioDonda requested review from jr0me and cborla August 13, 2024 15:20
TomasTurina
TomasTurina reviewed Aug 13, 2024
View reviewed changes
Copy link
Member

@TomasTurina TomasTurina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some function and classes comments are still incomplete.

Good job!

src/agent/queue/CMakeLists.txt Outdated Show resolved Hide resolved
src/agent/queue/CMakeLists.txt Outdated Show resolved Hide resolved
src/vcpkg.json Outdated Show resolved Hide resolved
src/agent/queue/tests/CMakeLists.txt Outdated Show resolved Hide resolved
src/agent/queue/include/queue.hpp Outdated Show resolved Hide resolved
src/agent/queue/src/main.cpp Outdated Show resolved Hide resolved
@LucioDonda LucioDonda force-pushed the 16-implement-queue-component branch from 58d51ec to fff83e9 Compare August 13, 2024 16:17
@LucioDonda LucioDonda requested a review from TomasTurina August 13, 2024 16:51
cborla
cborla approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@cborla cborla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LucioDonda LucioDonda force-pushed the 16-implement-queue-component branch from df461c2 to a00b81c Compare August 13, 2024 20:05
@LucioDonda LucioDonda force-pushed the 16-implement-queue-component branch from a00b81c to 942a905 Compare August 13, 2024 20:23
@TomasTurina TomasTurina merged commit a65a0e8 into master Aug 13, 2024
2 checks passed
@TomasTurina TomasTurina deleted the 16-implement-queue-component branch August 13, 2024 20:29
@LucioDonda LucioDonda mentioned this pull request Aug 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cborla cborla cborla approved these changes

@jr0me jr0me jr0me approved these changes

@TomasTurina TomasTurina TomasTurina approved these changes

@ncvicchi ncvicchi Awaiting requested review from ncvicchi

@nbertoldo nbertoldo Awaiting requested review from nbertoldo

Assignees

@cborla cborla

@LucioDonda LucioDonda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Queue Component
4 participants
@LucioDonda @cborla @TomasTurina @jr0me