fix(task_manager): update task manager start parameter to 4 in tests …

…and don't run start more than once given the nature of the condition variable, the lambda would be executed multiple times, resulting in more than one call to StartManager::Start
wazuh · Dec 11, 2024 · a0fca67 · a0fca67
1 parent 5b9d775
commit a0fca67
Showing 1 changed file with 19 additions and 4 deletions.
diff --git a/src/agent/task_manager/tests/task_manager_test.cpp b/src/agent/task_manager/tests/task_manager_test.cpp
@@ -24,7 +24,7 @@ class TaskManagerTest : public ::testing::Test
 
 TEST_F(TaskManagerTest, StartAndStop)
 {
-    taskManager.Start(2);
+    taskManager.Start(4);
     taskManager.Stop();
 }
 
@@ -37,13 +37,18 @@ TEST_F(TaskManagerTest, EnqueueFunctionTask)
     };
 
     taskManager.EnqueueTask(task);
+    bool taskManagerStarted = false;
 
     {
         std::unique_lock<std::mutex> lock(mtx);
         cv.wait(lock,
                 [&]()
                 {
-                    taskManager.Start(2);
+                    if (!taskManagerStarted)
+                    {
+                        taskManagerStarted = true;
+                        taskManager.Start(4);
+                    }
                     return taskExecuted.load();
                 });
     }
@@ -64,13 +69,18 @@ TEST_F(TaskManagerTest, EnqueueCoroutineTask)
     };
 
     taskManager.EnqueueTask(coroutineTask());
+    bool taskManagerStarted = false;
 
     {
         std::unique_lock<std::mutex> lock(mtx);
         cv.wait(lock,
                 [&]()
                 {
-                    taskManager.Start(2);
+                    if (!taskManagerStarted)
+                    {
+                        taskManagerStarted = true;
+                        taskManager.Start(4);
+                    }
                     return taskExecuted.load();
                 });
     }
@@ -92,13 +102,18 @@ TEST_F(TaskManagerTest, EnqueueFunctionTaskIncrementsCounter)
     };
 
     taskManager.EnqueueTask(task);
+    bool taskManagerStarted = false;
 
     {
         std::unique_lock<std::mutex> lock(mtx);
         cv.wait(lock,
                 [&]()
                 {
-                    taskManager.Start(2);
+                    if (!taskManagerStarted)
+                    {
+                        taskManagerStarted = true;
+                        taskManager.Start(4);
+                    }
                     return taskExecuted.load();
                 });
     }