Skip to content

Commit

Permalink
fix(centralizedConfiguration): remove the single quotation marks from…
Browse files Browse the repository at this point in the history
… the return message to avoid failures in updating the command in the database.
  • Loading branch information
Nicogp committed Dec 5, 2024
1 parent c55f273 commit 8776051
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ namespace centralized_configuration

m_reloadModulesFunction();

const std::string messageOnSuccess = "CentralizedConfiguration '" + command + "' done.";
const std::string messageOnSuccess = "CentralizedConfiguration " + command + " done.";
co_return module_command::CommandExecutionResult {module_command::Status::SUCCESS, messageOnSuccess};
}
catch (const nlohmann::json::exception&)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -159,13 +159,13 @@ TEST(CentralizedConfiguration, ExecuteCommandHandlesRecognizedCommands)
"set-group",
groupsList,
module_command::Status::SUCCESS,
"CentralizedConfiguration 'set-group' done.");
"CentralizedConfiguration set-group done.");

co_await TestExecuteCommand(centralizedConfiguration,
"update-group",
{},
module_command::Status::SUCCESS,
"CentralizedConfiguration 'update-group' done.");
"CentralizedConfiguration update-group done.");

co_await TestExecuteCommand(centralizedConfiguration,
"unknown-command",
Expand Down Expand Up @@ -228,7 +228,7 @@ TEST(CentralizedConfiguration, SetFunctionsAreCalledAndReturnsCorrectResultsForS
"set-group",
groupsList,
module_command::Status::SUCCESS,
"CentralizedConfiguration 'set-group' done.");
"CentralizedConfiguration set-group done.");

EXPECT_TRUE(wasSetGroupIdFunctionCalled);
EXPECT_TRUE(wasDownloadGroupFilesFunctionCalled);
Expand Down Expand Up @@ -286,7 +286,7 @@ TEST(CentralizedConfiguration, SetFunctionsAreCalledAndReturnsCorrectResultsForU
"update-group",
{},
module_command::Status::SUCCESS,
"CentralizedConfiguration 'update-group' done.");
"CentralizedConfiguration update-group done.");

EXPECT_TRUE(wasGetGroupIdFunctionCalled);
EXPECT_TRUE(wasDownloadGroupFilesFunctionCalled);
Expand Down

0 comments on commit 8776051

Please sign in to comment.