Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: do not include docs deps into CHANGELOG #740

Merged
merged 2 commits into from
May 27, 2024
Merged

ci: do not include docs deps into CHANGELOG #740

merged 2 commits into from
May 27, 2024

Conversation

lotyp
Copy link
Member

@lotyp lotyp commented May 27, 2024

Summary by CodeRabbit

  • Chores

    • Added a new job test-sqlite for testing on different PHP versions and dependencies.
  • Documentation

    • Updated renovate.json to include a new package rule for documentation dependencies, ensuring consistent commit messages and labels.

Copy link

vercel bot commented May 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
laravel-cycle-orm-adapter ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2024 9:30am

Copy link

coderabbitai bot commented May 27, 2024

Walkthrough

The recent updates introduce a new job, test-sqlite, in the GitHub Actions workflow to enhance testing across different PHP versions and dependencies. Additionally, the renovate.json file has been updated to include rules for documentation dependencies, streamlining their management and updates.

Changes

File Change Summary
.github/workflows/testing.yml Added a new job test-sqlite for testing on various PHP versions and dependencies.
renovate.json Added package rule for paths starting with docs/** to manage documentation dependencies.

Poem

In the garden of code, new tests bloom bright,
SQLite dances in the moonlit night.
Documentation sings with a Renovate tune,
Keeping updates smooth, like a soft monsoon.
🎉✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to full the review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added type: maintenance For maintenance, refactor and testing (perf, chore, style, revert, refactor, test, build, ci) type: enhancement For features and enhancements (feat) labels May 27, 2024
Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.94%. Comparing base (e3c5d00) to head (8039105).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #740   +/-   ##
=========================================
  Coverage     75.94%   75.94%           
  Complexity      252      252           
=========================================
  Files            46       46           
  Lines           927      927           
=========================================
  Hits            704      704           
  Misses          223      223           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between e3c5d00 and 8039105.
Files selected for processing (2)
  • .github/workflows/testing.yml (1 hunks)
  • renovate.json (1 hunks)
Additional comments not posted (1)
.github/workflows/testing.yml (1)

136-194: The configuration for the test-sqlite job looks good and aligns with the PR objectives.

Comment on lines +21 to +25
"paths": ["docs/**"],
"commitMessagePrefix": "chore",
"commitMessageAction": "update",
"commitMessageTopic": "docs dependencies",
"labels": ["type: docs", "type: deps"]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the commit message prefix to align with PR objectives.

- "commitMessagePrefix": "chore",
+ "commitMessagePrefix": "docs:",

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
"paths": ["docs/**"],
"commitMessagePrefix": "chore",
"commitMessageAction": "update",
"commitMessageTopic": "docs dependencies",
"labels": ["type: docs", "type: deps"]
"paths": ["docs/**"],
"commitMessagePrefix": "docs:",
"commitMessageAction": "update",
"commitMessageTopic": "docs dependencies",
"labels": ["type: docs", "type: deps"]

@lotyp lotyp merged commit 0cf891f into master May 27, 2024
24 checks passed
@lotyp lotyp deleted the feat/infra-dx branch May 27, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement For features and enhancements (feat) type: maintenance For maintenance, refactor and testing (perf, chore, style, revert, refactor, test, build, ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant