xwayland: destroy xdg role before surface #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #49 |
maxhbooth
force-pushed
the
bug/destroy-role-before-surface
branch
from
ae74275 to
8b62dc6
Compare
maxhbooth
force-pushed
the
bug/destroy-role-before-surface
branch
from
8b62dc6 to
1b76531
Compare
ethanpailes
reviewed
Jul 1, 2024
| @@ -402,6 +401,12 @@ impl WprsState { | |||
| .retain(|child_surface_id| child_surface_id != surface_id); | |||
| } | |||
| } | |||
|
|
|||
| // this MUST come after removing xwayland_surface, because xwayland_surface's role needs | |||
There was a problem hiding this comment.
Is there any way to express this constraint in the type system, or would it be too much of a pain/impossible to do so?
There was a problem hiding this comment.
I think that's probably too much work, since it seems like we'd have to combine surface_bimap and surfaces into a single field and refactor everything
ethanpailes
approved these changes
Jul 1, 2024
maxhbooth
force-pushed
the
bug/destroy-role-before-surface
branch
from
1b76531 to
0f0f391
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.