-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pt-PT
] Corrections and completion of the translation.
#38
Conversation
Hey @waydabber, is it possible to add @nunoebarros as a reviewer to keep track of the progress and get his approval for the new changes as well? Can you also link to this PR for issue #32? |
Hi @0rangeFox - when you mentioned #32 GitHub auto linked this PR to that. :) But the PR is still marked as draft and work in progress. Is that intentional? |
Well, I don't think it's going to the Development section here in PR, but I've marked it as Draft and it's not complete yet, it still needs to be worked on and the missing translations to be filled in. Another question, could you explain how I can merge the new translation file with the current one? I think it's a bit outdated compared to the last translation. |
Ok. I set it to "Ready to review", however I can't add any other reviewer. Should I just merge it? @nunoebarros can take a look at it and suggest corrections anytime I think. |
It's not available yet, I've only made the corrections and the rest of the translations have yet to be translated.
And how can I do this? |
Hi, the best course of action is that I merge the changes, import the file into the app and export an updated file you can continue working on. Otherwise the changes need to be merged if there are conflicts. |
(ok, there were no conflicts... :)). |
Ohhh, I didn't want you to merge, but you could have taken control of this PR and updated things yourself without having to merge. As I said things were still being corrected and translated. But I'd rather do it all at once in this PR than creating several for each correction/translation. Now it's gone and that's that. |
Oh, ok, sorry. You can create an other one and I'll keep it open, or you can just work in a fork you created and update strings whenever there is a change in this repo as you work. You can also work incrementally and create PRs periodically there are some changes that improve the situation instead of waiting for a PR until everything is perfect - this way whenever I create a version, the best currently available translation will be included in it. |
Hey 👋, here's the first PR for the
pt-PT
language with the aim of correcting and adding the missing translations from the last file.