Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pt-PT] Corrections and completion of the translation. #38

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

0rangeFox
Copy link
Contributor

Hey 👋, here's the first PR for the pt-PT language with the aim of correcting and adding the missing translations from the last file.

@0rangeFox
Copy link
Contributor Author

0rangeFox commented Apr 28, 2024

Hey @waydabber, is it possible to add @nunoebarros as a reviewer to keep track of the progress and get his approval for the new changes as well? Can you also link to this PR for issue #32?

@waydabber
Copy link
Owner

Hi @0rangeFox - when you mentioned #32 GitHub auto linked this PR to that. :) But the PR is still marked as draft and work in progress. Is that intentional?

@0rangeFox
Copy link
Contributor Author

0rangeFox commented Apr 29, 2024

Hi @0rangeFox - when you mentioned #32 GitHub auto linked this PR to that. :) But the PR is still marked as draft and work in progress. Is that intentional?

Well, I don't think it's going to the Development section here in PR, but I've marked it as Draft and it's not complete yet, it still needs to be worked on and the missing translations to be filled in.

Another question, could you explain how I can merge the new translation file with the current one? I think it's a bit outdated compared to the last translation.

@waydabber waydabber marked this pull request as ready for review April 29, 2024 14:33
@waydabber waydabber self-requested a review April 29, 2024 14:33
@waydabber
Copy link
Owner

Ok. I set it to "Ready to review", however I can't add any other reviewer. Should I just merge it? @nunoebarros can take a look at it and suggest corrections anytime I think.

@0rangeFox
Copy link
Contributor Author

0rangeFox commented Apr 29, 2024

It's not available yet, I've only made the corrections and the rest of the translations have yet to be translated.

Another question, could you explain how I can merge the new translation file with the current one? I think it's a bit outdated compared to the last translation.

And how can I do this?

@0rangeFox 0rangeFox marked this pull request as draft April 29, 2024 15:16
@waydabber
Copy link
Owner

Hi, the best course of action is that I merge the changes, import the file into the app and export an updated file you can continue working on. Otherwise the changes need to be merged if there are conflicts.

@waydabber waydabber marked this pull request as ready for review April 30, 2024 07:32
@waydabber waydabber merged commit 64ef76b into waydabber:main Apr 30, 2024
@waydabber
Copy link
Owner

(ok, there were no conflicts... :)).

@0rangeFox
Copy link
Contributor Author

Ohhh, I didn't want you to merge, but you could have taken control of this PR and updated things yourself without having to merge. As I said things were still being corrected and translated. But I'd rather do it all at once in this PR than creating several for each correction/translation. Now it's gone and that's that.

@waydabber
Copy link
Owner

Oh, ok, sorry. You can create an other one and I'll keep it open, or you can just work in a fork you created and update strings whenever there is a change in this repo as you work. You can also work incrementally and create PRs periodically there are some changes that improve the situation instead of waiting for a PR until everything is perfect - this way whenever I create a version, the best currently available translation will be included in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants