Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization: French #5

Open
waydabber opened this issue Dec 18, 2023 · 49 comments
Open

Localization: French #5

waydabber opened this issue Dec 18, 2023 · 49 comments
Assignees
Labels
localization ready Included in the stable release

Comments

@waydabber
Copy link
Owner

This is for the French localization

@waydabber waydabber self-assigned this Dec 18, 2023
@RaphaelSve
Copy link

I will help with bringing French localization 😀

@waydabber
Copy link
Owner Author

Thank you!

Here is the French localization file. You need XCode to work on it:

fr.xcloc.zip

If you have a partial translation, just let upload the file here and I can import it and see if it works + give a test build!

@waydabber waydabber transferred this issue from waydabber/BetterDisplay Jan 3, 2024
@waydabber
Copy link
Owner Author

I made some changes in how you BetterDisplay localization works. Here is the announcement: waydabber/BetterDisplay#2165 (comment)

@waydabber waydabber removed their assignment Jan 4, 2024
@waydabber
Copy link
Owner Author

Hi @RaphaelSve - thanks for volunteering to work on the French localization! Since there doesn't seem to be much progress/feedback on this, I need to ask - are you still working on this? If not, that is completely fine and I completely understand - but then I'll need to remove the translation placeholder files from the project for now (until there is an other volunteer of course). I ask this only to keep things in order and get a feel on how things are proceeding. Thank you! :)

@waydabber
Copy link
Owner Author

Hi there, since there seems to be no progress or any reply, I'll remove French form the repo/project for now. I can add it back anytime of course if there is a progress on it.

Here is the xcloc file for the current v2.3.1 app version:

fr.xcloc.zip

@waydabber waydabber added the not ready The completion level below ~90% - not included in stable release label Apr 14, 2024
@Kcraft059
Copy link
Contributor

I'll sure do my best to help too

@waydabber waydabber removed the not ready The completion level below ~90% - not included in stable release label Aug 15, 2024
@waydabber
Copy link
Owner Author

Thank you @Kcraft059!

@waydabber
Copy link
Owner Author

Hi @Kcraft059 - here is the file for localization (Use Xcode to open the file):

fr.xcloc.zip

@Kcraft059
Copy link
Contributor

Kcraft059 commented Aug 17, 2024

As promised here's my work so far I'd say I've done about 45-50% I'm dropping what I've done so far if it can be any usefull. (it might not be used right now because I need to make some revisions)

Localization file so far :
fr.xcloc.zip

@Kcraft059
Copy link
Contributor

Proud to show the completed French localization (I'm like 18-20 hours in so far). It still needs a revision but I'll wait to have the build with it included to make my revision & provide a fully usable xcloc. (even if the file I'll upload is complete some minor details might be inexacts or misleading it's why I want to make a revision with an app build to make sure everything is as clear as the original English translation)

Localization file so far :
fr-complete(needs-revision).xcloc.zip

Have a great day (or night for me and most of people in Europe & Africa) !!

@waydabber
Copy link
Owner Author

Amazing! Great job! 🥇 I'll build a version for verification. Will let you know when it's available!

@waydabber
Copy link
Owner Author

Here is a build with French incorporated for testing:

https://github.com/waydabber/BetterDisplay/releases/download/pre/BetterDisplay-v3.0.4-b33345.zip

If you need to change anything, just add an updated localization. Before proceeding however, download the latest version from the updated repo (https://github.com/waydabber/BetterDisplay-localization/archive/refs/heads/main.zip) and modify that!

Thank you! :)

@waydabber
Copy link
Owner Author

Ok, I forgot to do a proper push on the repo earlier, sorry. So now you can download the French localization added to the repo.

@Kcraft059
Copy link
Contributor

@waydabber Ok thank you for the build I’ll start working on it right now ! (It shouldn’t take an excessive time,I think the localization will completed in 1-2 days)

@Kcraft059
Copy link
Contributor

Kcraft059 commented Aug 20, 2024

There we are, finally it's finished. It was a great experience, and I'll be happy to make further translation for the upcoming versions of BD. Thank you especially @waydabber since you were a great help.

Here's the file, ready for release:
fr-final(ready-for-release).xcloc.zip

And now it's time for me to go to sleep(since it's 3am in France), wishing you to have a great day !!

PS: Let Me know when the localisation file will be included into an actual BD release ^^.

@waydabber
Copy link
Owner Author

Thank you! Amazing work! 💯

I'll provide an internal pre-release + push it via auto-update to subscribers as well later today! :)

@waydabber
Copy link
Owner Author

The latest internal pre-release is now available (if you are running an internal pre-release, you should simply check for updated)!

@waydabber
Copy link
Owner Author

Hi there, just released a version with the new French localization (currently auto-updates to pre-release users only, general rollout will follow if no issues are reported).

https://github.com/waydabber/BetterDisplay/releases

@Kcraft059
Copy link
Contributor

I reviewed again and found some littles/minors grammar/Case/typo errors, so I fixed them… Nothing absolutely urgent but I feel I should fix them before forgetting, anyway here's the file:

fr-minor_improvements.xcloc.zip

@waydabber
Copy link
Owner Author

Thank you, I'll add this to the next build!

@Kcraft059
Copy link
Contributor

Ok a bit late but I noticed there was a new update so I added the needed translation.
There it is:
fr.xcloc.zip

Have a great day !

@waydabber
Copy link
Owner Author

Thank you!

@Kcraft059
Copy link
Contributor

Kcraft059 commented Oct 1, 2024

Hey !! It's that time of the month again, I noticed a new update and therefore there's the updated localization file:
fr.xcloc.zip

As always have a great day, and if there's any problems in the translation let me know !

Ps : I've just entered high school for a month, for now there isn't much work to do so I can still manage to translate when I get time but, in the upcoming months, I could hypothetically make a bit less progress on the translation, but as always, I'll do my best !!

@waydabber
Copy link
Owner Author

Amazing, thank you! Good luck with your studies! :)

@SakiPapa
Copy link
Contributor

SakiPapa commented Oct 5, 2024

Oh! I'm high school retired teacher in Japan!!
Have a good school life (^_^)V

@Kcraft059
Copy link
Contributor

Kcraft059 commented Oct 11, 2024

Still there to post translation updates:
I've corrected one or two little errors, and added translation for the new dialogs. So there we have it (still one release late but nvm) !

localization for v3.1.2 -> fr.xcloc.zip

As always (even if it's repetitive), have a great day !
Ps : If someone know how I could get notifications when a new xcloc file needs to be completed because each time I notice it after the update is rolled out and therefore my translation isn't complete for the release. Thx in advance ^^

@waydabber
Copy link
Owner Author

Thank you! :)

You can simply watch this repo for activitites - this way you'll know when some new strings are added!

@Kcraft059
Copy link
Contributor

Kcraft059 commented Oct 31, 2024

Little update on the loc: I noticed few lines remained untranslated so I translated as usual...

localization for BD v3.1.2 -> fr.xcloc.zip

Have a great day !
PS: Since I usually post updates here I was wondering about trying to use git and make pull request instead of uploading the file here each time (so it'll be less annoying for you) but I never did that so if you could recommend me something to get into git and understand how it work (don't worry I could manage to understand even with something complicated). No pressure ofc if you're not in the mood I'll try to do it myself.

@waydabber
Copy link
Owner Author

Thank you @Kcraft059!

Posting zip files is fine, it is actually easier me since I have to add the translation to the code project and then export it and re-add it to the translation repo. But the GitHub PR way is fine and useful especially if multiple translators work rapidly or want changes to be easily received into your fork.

Making PRs is easy - you simply need to fork the project, clone the forked project, edit whatever you want, commit it and then create a PR. The easiest way is to download GitHub Desktop as it does all this for you in a simple UI.

@waydabber
Copy link
Owner Author

Added an interim pre-release with the latest translation!

@Kcraft059
Copy link
Contributor

@waydabber Oh ok if it’s easier for you no problem I’ll stay with zip files, git (actually I’m the most interested by the git CLI) was rather for my own knowledge, and if it could have simplified your work I’d use it but since it isn’t I’ll just try to learn it for personal use only, but thank you for the advice and of course I’ll keep up with the translation!
(And thx for the pre-release)

@waydabber
Copy link
Owner Author

The translation now stands at 99%! I uploaded a new interim pre-release with the changes! Thanks again!

@Kcraft059
Copy link
Contributor

Translated !

localization for BD v 3.1.3 -> fr.xcloc.zip

PS : The more I think at it the more I'm sure that I'll try to stay translating this app as long as I can, when I started I thought that I'd stop a bit after. But contributing to something useful is something that I really like much.

Anyway I wish you a great day ! (I'm afraid it looses it's meaning after saying it too much time… 😅)

@waydabber
Copy link
Owner Author

Thank you @Kcraft059! :)

@GeorgeKA
Copy link
Contributor

Hi @waydabber. I'm interested in contributing if you're still looking for help

@waydabber
Copy link
Owner Author

Hey @GeorgeKA - we have @Kcraft059 contributing now actively on this, but I am sure some help in peer reviewing existing translations will come handy. What do you say @Kcraft059?

@Kcraft059
Copy link
Contributor

Actually, to make this quick, I was just waiting for your answer @waydabber. I’m not sure if I can work in group but I’ll I make my best. It’s just that I’m not sure about how we’re gonna organize ourselves if you have any proposition @GeorgeKA let me know.
(only problem that I could see is that there isn’t much to translate at the moment so the only thing you could do right now is just revising some of my old translation and it might not be really funny.)
For the upcoming translation I don’t how you want to do but I personally translate the loc as soon as notice it - which can sometimes take 3 to 4 days .
But anyway, great to have you helping us, thank you and let me know how you want to help !

@GeorgeKA
Copy link
Contributor

Hmm, okay. Not trying to step on anyone's toes. I just found the app useful and figured I could lend a hand.
I can peer review some of the entries that stuck out to me, and I'll be around if you want to offload some of the work @Kcraft059 .

@Kcraft059
Copy link
Contributor

Oh my apologies @GeorgeKA if you took it badly, I… it’s not that I don’t want help or that I want to do it all by myself at all, of course I’ll appreciate a lot to get your help. It’s just that I don’t want you to just make the annoying part of it. (Because let’s be real reviewing is not quite a dream job 😅) But also I agree that reviewing needs to be made so if you’re ok with doing it, it’s great !!
And so if you want to start the review and the work on this translation you can report me any misleading or erroneous translation.
If you want to stay with the long term translation of the app you can reach me here or on my Discord @kcraft059 so we can organize better for the upcoming work.

@GeorgeKA
Copy link
Contributor

Sounds good @Kcraft059 .
@waydabber I think I need to be granted the authorization to push changes, right?

@waydabber
Copy link
Owner Author

@GeorgeKA - you can simply create a pull request any time from your fork of the repo.

@waydabber
Copy link
Owner Author

There is a new pre-release with the latest localizations. https://github.com/waydabber/BetterDisplay/releases

If everything goes well, I will soon release a proper stable version. Just wanted to let you know as you may want to have some of the missing strings localized so it will be 100% in the release. :)

@Kcraft059
Copy link
Contributor

Ok I translated the remaining strings, here's the loc, and @GeorgeKA if you want to review it you're welcome :

French loc for BD v 3.2.0 -> fr.xcloc.zip (I'll also try to make a push request)

Have a great day !

@waydabber
Copy link
Owner Author

Thank you, I merged the localizations - since there was 1 conflict, just to make sure please review the end result. :) Thanks to both of you!

@waydabber
Copy link
Owner Author

i noticed the attached localization (above) had some additional strings over the ones in the pull request. Tried to combine them. The result should now be in the repo.

@Kcraft059
Copy link
Contributor

Kcraft059 commented Nov 24, 2024

Yup sorry @waydabber for all of that we’re trying to organize (or rather I am but anyway) thank you for your help, my pull request was just a modified version of the first pull request but since I couldn’t modify the first one I did my own repo and I added access to @GeorgeKA.
(edit: you merged it successfully don’t worry)

@waydabber
Copy link
Owner Author

waydabber commented Nov 24, 2024

Uploaded an updated internal pre-release with the latest translations! :)

@Kcraft059
Copy link
Contributor

Kcraft059 commented Nov 24, 2024

Ok thx ! I’ll check it !

@waydabber
Copy link
Owner Author

Thanks @Kcraft059 - French is now at 100% again!

@waydabber waydabber added the ready Included in the stable release label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization ready Included in the stable release
Projects
None yet
Development

No branches or pull requests

5 participants