Upgrade to modern PHP #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zero4Five9
reviewed
Apr 19, 2023
| @@ -6,5 +6,9 @@ | |||
| "psr-4": { | |||
| "Vouchers\\": "src/Vouchers" | |||
| } | |||
| }, | |||
| "require-dev": { | |||
| "phpunit/phpunit": "^10.0", | |||
There was a problem hiding this comment.
It would be great to add "php": 8 to ensure that composer would complain given any package in the future isn't compatible.
Zero4Five9
reviewed
Apr 19, 2023
| @@ -46,7 +46,7 @@ public function __construct(\Vouchers\Voucher\Model $model = null) | |||
| * | |||
| * @return void | |||
| */ | |||
| public function fill($number = 0) | |||
| public function fill($number = 0) :void | |||
There was a problem hiding this comment.
The spacing is it a little off here... ideally "): void"
Zero4Five9
reviewed
Apr 19, 2023
| @@ -46,7 +46,7 @@ public function __construct(\Vouchers\Voucher\Model $model = null) | |||
| * | |||
| * @return void | |||
| */ | |||
| public function fill($number = 0) | |||
| public function fill($number = 0) :void | |||
Zero4Five9
reviewed
Apr 19, 2023
| */ | ||
| public function find($code) | ||
| public function find($code) :bool|Voucher |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request to modernize the code of this library, setting the minimm requirement at PHP8. With this PR we,
@ExpectedExceptiondocblock.__callfunction to allow for magic getters and setters using getOurValue() or setOurValue('thing') operations to get and set data on our data array, where OurValue maps to our_value in the data array.** Ignore failed styleci actions.
** Code outside of this PR doesn't overly need to be considered, except where traits of interfaces may have an impact.