Improve C library performance for 2in13 V2 #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply the same technique from waveshareteam#104 and waveshareteam#130 to the C library. The low level lib provides a function to send byte arrays instead of single bytes. Where possible loops and multiple single byte send calls were replaced with this function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The C libraries can be improved in a similar way to #104 and #130.
Single byte writes in loops were replaced with their multi-bytes variations.
This results in a significant performance improvement (~100% on my Pi Zero)
In addition I've replaced
printf()s withDebug()and disable the debugging flag in the Makefile because libraries in production shouldn't really write to stdout/-err.