Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config.py #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update config.py #12

wants to merge 1 commit into from

Conversation

userh23
Copy link

@userh23 userh23 commented Feb 2, 2021

No description provided.

@jesgome
Copy link

jesgome commented Apr 22, 2022

Would you elaborate on why this is a better setting for SPI.max_speed_hz variable?

I can confirm that the code still compiles and reads well with your update. I just can't see what improvement it makes on what it was before.

Edit: I just tested data collection and can see that hi data throughput is much faster with your update. It may seem better at face value but I'm a little concerned this may affect measurement error tolerance. I'll respond with a reply later when I have a better sense of measurement error with your update.

Edit: I performed a rough test on measurement error tolerance and it does seem that this update has a minor increase in noise in the measurement of voltages. The increase is small and tolerable depending on what degree of certitude the user requires and if the speed increase is warranted for their application. I would still say leave the config.py module as is and do not merge this with the library but rest assured it will work if you choose to modify your own library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants