Use native DB type in injected auth models if user uses it #2243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mihovil Ilakovac <[email protected]>
infomiho
force-pushed
the
miho-user-id-native-db-type
branch
2 times, most recently
from
aafbb7a
to
d08e324
Compare
infomiho
force-pushed
the
miho-user-id-native-db-type
branch
from
d08e324
to
048d804
Compare
Martinsos
reviewed
Aug 29, 2024
waspc/src/Wasp/Psl/Ast/Attribute.hs
Outdated
|
|
||
| -- | @db.Uuid or @db.String or @db.VarChar are examples of native db types. | ||
| isNativeDbTypeAttr :: Attribute -> Bool | ||
| isNativeDbTypeAttr = isPrefixOf "db." . _attrName |
There was a problem hiding this comment.
Suggested change
| isNativeDbTypeAttr = isPrefixOf "db." . _attrName | |
| isNativeDbTypeAttr = ("db." `isPrefixOf`) . _attrName |
reads nicer :D
Martinsos
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
A lot of AST here which is a bit hard to read / maintain -> any way we might be able to replace it with actual PSL, here in the test? That is parsed either during test runtime, or even test compile time if that is doable (although I think I remember we had hard time with that).
If not, never mind, but if yes, I think it could make the test easier to read and maintain.
There was a problem hiding this comment.
That is parsed either during test runtime
I've done this bit since it was similar to something we already did with the full schema file.
wasp/waspc/test/Util/Prisma.hs
Line 10 in 362ccff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2167