Make operations work with any
#2170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sodic
commented
Jul 9, 2024
Comment on lines
64
to
65
| Expect<Equal<typeof getAnyNoAuth, QueryMetadata & ((args: any) => Promise<any>)>>, | ||
| Expect<Equal<typeof getAnyAuth, QueryMetadata & ((args: any) => Promise<any>)>>, |
Comment on lines
107
to
108
| Expect<Equal<typeof getAnyNoAuth, (args: any) => Promise<any>>>, | ||
| Expect<Equal<typeof getAnyAuth, (args: any, ctx: { user: AuthUser }) => Promise<any>>>, |
|
|
||
| export const testingAction: TestingAction = async (args, context) => { | ||
| // todo(filip): When sorting out the tests, we should also test whether the | ||
| // TODO: (Filip) When sorting out the tests, we should also test whether the |
There was a problem hiding this comment.
I changed how I write these notes because my editor nicely highlights them if they start with TODO:
infomiho
approved these changes
Jul 9, 2024
This reverts commit a9f6f44.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce
In
0.14.0-rc1:any(either explicitly or because they are using JS). For example:getFoohas type() => Promise<any>getFoohas type() => Promise<any>if non-authenticated or(ctx: ...) => Promise<any>if authenticated.Expected behavior:
The types should be
(args: any) => Promise<any>and(args: any, ctx: ...) => Promise<any>.Explanation
We wanted to expose void operations as receiving no arguments (#2004).
To do so, we check whether
Input extends voidand act accordingly.Unfortunately,
anyextendsvoidas well, which made us treat an operation with input of typeanylike it had input of typevoid.To fix it, we now first check whether the input is of type
any.