update stripe sdk and webhooks to match #427
Open
+95
−94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincanger
commented
May 14, 2025
| @@ -24,7 +24,7 @@ | |||
| "react-hot-toast": "^2.4.1", | |||
| "react-icons": "4.11.0", | |||
| "react-router-dom": "^6.26.2", | |||
| "stripe": "11.15.0", | |||
| "stripe": "^18.1.0", | |||
There was a problem hiding this comment.
according to new stripe update policy, this will avoid breaking changes.
vincanger
commented
May 14, 2025
| // We do this so that we can capture priceId in the payment_intent.succeeded webhook | ||
| // and easily confirm the user's payment based on the price id. For subscriptions, we can get the price id | ||
| // in the customer.subscription.updated webhook via the line_items field. | ||
| payment_intent_data: paymentIntentData, |
There was a problem hiding this comment.
we're no longer dealing with payment intents to handle one-time payment products. these are now just getting handled directly in checkout.session.completed.
vincanger
commented
May 14, 2025
| @@ -32,8 +32,8 @@ export const stripeWebhook: PaymentsWebhook = async (request, response, context) | |||
| case 'invoice.paid': | |||
| await handleInvoicePaid(data, prismaUserDelegate); | |||
| break; | |||
| case 'payment_intent.succeeded': | |||
| await handlePaymentIntentSucceeded(data, prismaUserDelegate); | |||
| case 'customer.subscription.created': | |||
There was a problem hiding this comment.
subscription created events used to be sent in customer.subscription.updated events, but they stopped that , so to handle new subscriptions we need this event.
vincanger
commented
May 14, 2025
| export async function handleInvoicePaid(invoice: InvoicePaidData, prismaUserDelegate: PrismaClient['user']) { | ||
| const userStripeId = invoice.customer; | ||
| const datePaid = new Date(invoice.period_start * 1000); | ||
| return updateUserStripePaymentDetails({ userStripeId, datePaid }, prismaUserDelegate); | ||
| const lineItems = await invoiceLineItemsSchema.parseAsync(invoice.lines); |
There was a problem hiding this comment.
Not sure if this is needed, because we can be certain that stripe is going to send us the correct format, right?
This was referenced May 19, 2025
Closed
|
I'll take a look tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #229 #198 #293 #412
Contributor Checklist