[Demo App] decrement credits only if user doesn't have subscription plan #425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sodic
reviewed
May 22, 2025
| console.log('Decrementing credits and saving response'); | ||
| prisma.$transaction([decrementCredit, createResponse]); | ||
| await prisma.$transaction(transactions); |
| @@ -81,18 +74,35 @@ export const generateGptResponse: GenerateGptResponse<GenerateGptResponseInput, | |||
| }, | |||
| }); | |||
|
|
|||
| const transactions: PrismaPromise<User | GptResponse>[] = [createResponse]; | |||
There was a problem hiding this comment.
Do you need the explicit type annotation here?
There was a problem hiding this comment.
It complains when i try to push thedecrementCredits transaction if I already define it with [createResponse].
Instead, I could define an empty array and then push both transactions without needing the explicit type annotation, like this:
const transactions = [];
transactions.push(createResponse);
if (!isUserSubscribed(context.user)) {
//...
transactions.push(decrementCredit);
}I'm not sure which is cleaner tbh.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #418