Take into account requirements for "isolate" or single-threaded runtimes #5284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...since it's not necessarily creating a store anymore.
Note: the removal of the reference for `StoreSnapshots` in `TaskWasm` in favour of an owned value is due to an initial work for making `TaskWasm` `Send` or not leaking references that outlive spawned threads.
theduke
reviewed
Dec 5, 2024
| #[cfg(feature = "js")] | ||
| Self::Js(_) => crate::RuntimeKind::Js, | ||
| #[cfg(feature = "jsc")] | ||
| Self::Jsc(_) => crate::RuntimeKind::Jsc, |
There was a problem hiding this comment.
If this is public, it needs to be #[non_exhaustive]
lib/api/src/entities/store/inner.rs
Outdated
| @@ -19,6 +19,9 @@ pub(crate) struct StoreInner { | |||
| pub(crate) on_called: Option<OnCalledHandler>, | |||
| } | |||
|
|
|||
| unsafe impl Send for StoreInner {} | |||
There was a problem hiding this comment.
We should very much not have this on the whole StoreInner.
If we need it for one particular variant, it should be on that variant. (v8)
There was a problem hiding this comment.
Removed it in c463031. BTW, v8 is technically the only one that should not be Send.
| let store_ref = store.as_store_ref(); | ||
| let v8_store = store_ref.inner.store.as_v8(); | ||
|
|
||
| if v8_store.thread_id != std::thread::current().id() { |
There was a problem hiding this comment.
This is used a lot... how about making it a method?
| task.spawn_type, | ||
| task.update_layout, | ||
| )?; | ||
| //let module = task.module; |
| @@ -240,6 +240,11 @@ impl crate::Engine { | |||
| _ => panic!("Not a `jsc` engine!"), | |||
| } | |||
| } | |||
|
|
|||
| /// Return true if [`self`] is an engine from the `jsc` runtime. | |||
| pub fn is_jsc(&self) -> bool { | |||
There was a problem hiding this comment.
Why does the js engine have a is_jsc method?
There was a problem hiding this comment.
This is in jsc/entities/engine.rs. Am I missing something?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V8 needs Wasm entities to be created in the same thread they run in. This PR moves the creation of said entities down to the
task_wasmfunction in WASIX.Caveats
This depends on a build of V8 with shared memory, which is not available yet - that is, running the precise code in this PR with wordpress won't work (again, because the wasm_c_api implementation of V8 does not support shared memories)