Deprecation of mb_convert_encoding with HTML-ENTITIES in PHP 8.2 #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wasinger
reviewed
May 31, 2023
There was a problem hiding this comment.
Symfony DOM Crawler (from which this code was taken originally) now uses mb_encode_numericentity, see https://github.com/symfony/dom-crawler/blob/6.3/Crawler.php#L1111
I'd prefer using the symfony approach to keep compatibility as high as possible (If the parseXhtml and convertToHtmlEntities methods were not private in the Crawler base class, I would definitely use them directly.)
|
The latest master version now uses the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://php.watch/versions/8.2/mbstring-qprint-base64-uuencode-html-entities-deprecated#html for workaround