Bugfix: setText() should convert special chars. Closes #34.

wasinger · Jun 28, 2019 · 6c3e391 · 6c3e391
1 parent b1d0aad
commit 6c3e391
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/Tests/HtmlPageCrawlerTest.php b/Tests/HtmlPageCrawlerTest.php
@@ -693,6 +693,14 @@ public function testText()
         $this->assertEquals('jklojklo', $c->text());
     }
 
+    public function testSetText()
+    {
+        $c = HtmlPageCrawler::create('<div>&quot;</div>');
+        $this->assertEquals('"', $c->text());
+        $c->setText('&');
+        $this->assertEquals('&', $c->text());
+    }
+
     public function testMagicGet()
     {
         // $crawler->length should give us the number of nodes in the crawler

diff --git a/src/HtmlPageCrawler.php b/src/HtmlPageCrawler.php
@@ -735,6 +735,7 @@ public function getCombinedText()
      */
     public function setText($text)
     {
+        $text = htmlspecialchars($text);
         foreach ($this as $node) {
             /** @var \DOMNode $node */
             $node->nodeValue = $text;