Expose Schema Registry Port #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianshih1
commented
Nov 20, 2024
| @@ -13,14 +13,22 @@ spec: | |||
| type: ClusterIP | |||
| clusterIP: None | |||
| ports: | |||
| {{- if or (.Values.config.playground) (not (hasPrefix "vci_sr_" .Values.config.virtualClusterID)) }} | |||
There was a problem hiding this comment.
we only want to expose the Kafka port if:
- we're in playground mode, in case we run a Kafka server on 9092 and a schema registry server on 9094
- we're dealing with a Kafka virtual cluster, which will never start with
vci_sr_as that is reserved for schema registry.
There was a problem hiding this comment.
is this overkill? Or we can just always expose 9094 and 9092
rmb938
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conditionally expose port
9092for Kafka clusters (or playground) and9094for Schema Registry clusters (or playground)