feat(buffer_memory): spillover and active metrics #575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds two new metrics to the 'memory' buffer which track the active number of bytes in the buffer and number of bytes that have been spilled due to reaching maximum capacity.
gregfurman
reviewed
Nov 27, 2025
Collaborator
gregfurman
left a comment
gregfurman
left a comment
There was a problem hiding this comment.
Looks good! I think we should just mention in the docs that the active_bytes and buffer_spillover are now going to be tracked. Once done, happy to approve and ship 
|
|
||
| for (m.bytes + extraBytes) > m.cap { | ||
| if m.spilloverEnabled { | ||
| m.spilloverBytes.Incr(int64(extraBytes)) |
Collaborator
There was a problem hiding this comment.
nit: This Incr definitely looks like it'd benefit from generics given this unnecessary conversion 🤔
Comment on lines
+132
to
+133
| activeBytes: res.Metrics().NewGauge("buffer_active"), | ||
| spilloverBytes: res.Metrics().NewCounter("buffer_spillover"), |
Collaborator
There was a problem hiding this comment.
Can you add a note in the docs that these metrics will now be tracked?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two new metrics to the
memorybuffer which track the active number of bytes in the buffer and number of bytes that have been spilled due to reaching maximum capacity.Resolves #574