Adding gRPC plugin #458
Adding gRPC plugin #458
Conversation
|
@akoserwal - thanks again for the effort - I see that the name of the PR is prefixed 'DRAFT:' but the PR isn't marked as draft. Should this be marked as Draft? Is it ready for review or are more changes coming? |
yes, it should be Draft for now |
client stream, and bidirectional stream.
|
warning there is a binary in the PR cmd/tools/grpc_test_server/grpc_test_server |
Signed-off-by: Jem Davies <[email protected]>
There was a problem hiding this comment.
I think that this approach using protoreflect is much better than the previous PR add gRPC support - having to have to link code before compilation wouldn't really fit with Bento.
But then there is still a lot of issues with the PR as it currently stands.
I feel like in the last PR (linked above) I gave the idea of using the http components as inspiration for the gRPC components - they are quite similar in many ways. But it doesn't seem like much of what we have here is similar to that - and therefore not idiomatic to the project.
I have started to implement a grpc_client output on #546 - which is using the http client as a guide - so we have sync responses & oAuth2 ...
Also a lot of the code pertains to connection_pool & session manager - and I am not sure how important that is going to be.
3 participants
closes #433