Keep TUI zero state stable during shell startup - #14632
Open
warp-agent-staging[bot] wants to merge 1 commit into
Open
Keep TUI zero state stable during shell startup#14632warp-agent-staging[bot] wants to merge 1 commit into
warp-agent-staging[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Starting shell...hint is visible.Originating thread: https://warpdotdev.slack.com/archives/C0BDQDW8V5E/p1785652323329829
Linked Issue
tmux capture-paneproof is included below.Testing
zero_state_position_stays_stable_across_shell_bootstrapfailed before the fix and passes after it.bootstrap_renders_starting_shell_above_inputandlong_running_command_keeps_input_hiddenpass../script/format --checkcargo clippy -p warp_tui --all-targets --tests -- -D warningscargo nextest run -p warp_tui --lib— 949/949 passed.cargo build -p warp_tui --bin warp-tui-osscargo build -p warp_tui --bin warp-tui-devFull workspace presubmit completed format, inline-test, clippy, clang-format, and WGSL checks, but its workspace-test phase exceeded the sandbox target filesystem twice (
No space left on device); the scoped TUI suite and PR CI are fully green.Real live TUI proof
These frames came directly from
tmux capture-panewhile one authenticatedwarp-tui-devprocess ran in an 80×40 PTY. They are terminal output from the real TUI, not replayed presenter buffers.Relevant lines (one-based
capture-paneoutput; equivalent zero-based rows are 13/32/33):Agent Mode
CHANGELOG-TUI: Fixed the zero state shifting when shell startup completes.
Rework changes
Starting shell...disappears.Conversation: https://staging.warp.dev/conversation/5020fa91-cade-4b17-8d57-af8c5de70f0c
Run: https://oz.staging.warp.dev/runs/019fc139-4de5-70c1-a4ef-4a772853163a
Co-Authored-By: Oz oz-agent@warp.dev
This PR was generated with Oz.