APP-2527: Specs for MCP tool call JSON tree rendering#12818
Draft
cephalonaut wants to merge 4 commits into
Draft
APP-2527: Specs for MCP tool call JSON tree rendering#12818cephalonaut wants to merge 4 commits into
cephalonaut wants to merge 4 commits into
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>
cephalonaut
changed the title
… component, design alternatives, and phased impl Co-Authored-By: Oz <oz-agent@warp.dev>
PRODUCT.md: clarify Behavior 8 (annotation count is sole non-empty signal), fix Behavior 12 (no ambiguous 'or disabled chevron'), add Behavior 16 (response arrives while header collapsed), add Behavior 17 (tree scroll/max-height), renumber downstream behaviors, fix Copy semantics (no-op without selection), unify context menu description for node rows and section labels. TECH.md: add color mapping to Design §A1, use Vec<PathSegment> not Rc<[PathSegment]> as HashMap key, define LONG_STRING_THRESHOLD=120, remove render_expansion_icon cross-module dependency (use warpui icons directly), move mcp_result_to_renderable test note to Phase 2 and fix name, add SelectableArea+Hoverable interaction risk, add scrollable tree body and correct behavior refs in Phase 3, update testing table with new behavior numbers. Co-Authored-By: Oz <oz-agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a product spec and tech spec (no code changes) for rendering MCP tool call JSON requests and responses in the Warp client as a collapsible tree instead of an unformatted pretty-printed JSON blob.
Specs live in
specs/APP-2527/:PRODUCT.md— user-facing behavior as numbered, testable invariants: collapsible nodes with chevron expanders, theme-colored keys/values by type, long-string elision that expands in place, request/response sections, default expansion state, selection/copy, and malformed/streaming edge cases.TECH.md— implementation plan grounded in the current rendering path (requested_command.rsshould_render_mcp_contentbranch,block.rsMCPcommand_textconstruction,CallMCPToolResult), proposing a newmcp_json_treemodule, path-keyed expansion state onRequestedCommandView, and theme-token-driven typed colors. Includes tradeoffs, testing/validation mapped to the product invariants, risks, and follow-ups. Code references are pinned to commit46265f4.The visual treatment follows Warp UI conventions; the originating request included a reference screenshot of a generic collapsible JSON tree.
Linked Issue
APP-2527
Agent Mode
Conversation: https://staging.warp.dev/conversation/16b6d33c-f180-45bb-82f7-8b721b09d153
Run: https://oz.staging.warp.dev/runs/019edddf-9ac8-7afd-8ac1-84888afdac83
This PR was generated with Oz.