Skip to content

Add completion spec: pkill (pkill)#270

Open
maro20066600 wants to merge 1 commit into
warpdotdev:mainfrom
maro20066600:maro/command-spec-pkill
Open

Add completion spec: pkill (pkill)#270
maro20066600 wants to merge 1 commit into
warpdotdev:mainfrom
maro20066600:maro/command-spec-pkill

Conversation

@maro20066600
Copy link
Copy Markdown

Summary

  • add a pkill command signature with process-name completions
  • add dynamic generators for process names and user-name arguments
  • register the pkill generators in command-signatures

Related to warpdotdev/warp#10974 and warpdotdev/warp#10924.

Testing

  • npm run format -- command-signatures/json/pkill.json
  • cargo fmt --check
  • cargo test -p warp-command-signatures pkill
  • cargo test -p warp-command-signatures
  • script/presubmit

@cla-bot cla-bot Bot added the cla-signed label May 15, 2026
Copy link
Copy Markdown
Contributor

@lucieleblanc lucieleblanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @maro20066600 , thank you for the contribution. Since this PR adds generators, could you provide screenshots of the generators working in a local build of Warp? This process is explained in the test-local-warp skill.

I'll be happy to review this again once screenshots are uploaded and displayed in the PR description or a comment. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants