[RFC] Use HKDF to expand group strings #5
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Watson Ladd said on the CFRG list that if I wrote the code and the text for this, it'd go in. This initial posting probably shouldn't go in as-is, for the following reasons:
$PWD
to runsetup.py test
, the tests passed.Also, I go a bit beyond simply switching to HKDF - the commits are probably in ascending order of controversy.
Review would be greatly appreciated.