Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Use HKDF to expand group strings #5

Closed
wants to merge 5 commits into from

Conversation

eternaleye
Copy link
Contributor

Watson Ladd said on the CFRG list that if I wrote the code and the text for this, it'd go in. This initial posting probably shouldn't go in as-is, for the following reasons:

  • I do not know where the text of the draft is to make those changes
  • The HKDF library I used was not detected properly by setup.py after I installed it with pip; as it's a single .py file, it may be worthwhile to simply vendor it in.
    • Do note, though, that when I manually put it in $PWD to run setup.py test, the tests passed.
  • There are other cases beyond the group strings, such as transcript -> key, that really ought to use HKDF in my opinion.

Also, I go a bit beyond simply switching to HKDF - the commits are probably in ascending order of controversy.

Review would be greatly appreciated.

@warner
Copy link
Owner

warner commented May 10, 2016

Thanks for the patches! I've rebased some, fixed others, and added some new work on top, in PR #6. Let me know what you think. I ended up deleting the scalar-hasher entirely, and simplified the Group constructor a bit in the process.

@warner warner closed this in 067e094 May 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants