fixed breaking change for Gatsby v4 #66
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaypalmer12
approved these changes
Mar 15, 2022
|
i've tested this out myself and seems to work as expected, @wardpeet can we get this merged? |
|
@wardpeet is there a chance we can get support for v4? :) |
talha-akram
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps up Gatsby version compatibility for the plugin. Also, fixes the breaking change where
loadPageSyncandloadPageare now being passed query params i.e.window.location.searchappended to thewindow.pathname. This is the line which does that. I have verified this fix for our app and it seems to be working.Issues that can be closed:
FYI, @wardpeet . Thanks