Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add postgresql support #754

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

bap14
Copy link
Member

@bap14 bap14 commented Feb 26, 2024

After adding the PostgreSQL images, this adds support to warden environments (or should). This emits a warning that using partials like db.base.yml or db.darwin.yml are deprecated and should be replaced with db.mysql.base.yml or db.mysql.darwin.yml.

I tested the DB connection and DB dump commands for PostgreSQL and they worked.

@bap14
Copy link
Member Author

bap14 commented Feb 26, 2024

The default is still mysql / mariadb. It adds a new WARDEN_DB_SYSTEM variable that is either mysql / mariadb or postgres. It will include the proper partial(s).

The current drawback is that only one database is allowed at a time, so you can't run both mysql and postgres. That's a feature that could be done in the future, but at the moment the key was to get it functioning.

@navarr
Copy link
Member

navarr commented Feb 26, 2024

Thanks for your hard work here, @bap14! Looks like I have a lot to review tomorrow.

I will likely change or request changed the name to match a wip PR I have to align env variables with Den.

But I'm excited to take a deeper look at this tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

2 participants