Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize ProfileSelectWindow #17

Draft
wants to merge 42 commits into
base: master
Choose a base branch
from

Conversation

shoushou1106
Copy link

shoushou1106 and others added 30 commits August 28, 2023 17:38
change Add
add Delete
change Window size & Title
@wannkunstbeikor wannkunstbeikor linked an issue Oct 19, 2023 that may be closed by this pull request
FrostyEditor/Assets/FrostyLogo.svg Outdated Show resolved Hide resolved
FrostyEditor/Assets/Profiles/Banners/bf2042.png Outdated Show resolved Hide resolved
@@ -31,6 +33,52 @@ public ProfileConfig(string inKey)
Key = inKey;
Path = Config.Get("GamePath", string.Empty, ConfigScope.Game, Key);
Name = ProfilesLibrary.GetDisplayName(Key) ?? Key;
Icon = BitmapAssetValueConverter.Instance.Convert($"avares://FrostyEditor/Assets/Profiles/Icons/{ProfilesLibrary.GetInternalName(inKey)}.png");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the icon/banner should probably be in a folder which the user can add, since profiles should be added through the user

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

user should can add banner manually?
can u see this? I think it would be better to make the banner part of the theme

Foreground="{DynamicResource DockThemeForegroundBrush}"
Background="{x:Null}"
BorderThickness="1" BorderBrush="{DynamicResource DockThemeBorderLowBrush}"
ExtendClientAreaToDecorationsHint="True"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does not work on linux, so i think it would be best to just have the title in the window decorations

Copy link
Author

@shoushou1106 shoushou1106 Nov 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

图片

just have the title in the window decorations

will cause this in win11, i will try make auto detect windows and custom titlebar in ThemeSystem

@wannkunstbeikor wannkunstbeikor marked this pull request as draft October 20, 2023 15:15
@shoushou1106
Copy link
Author

shoushou1106 commented Nov 4, 2023

btw the AcrylicBorder in MainWindow looks so weird (i didnt change that)
图片

And im working on ThemeSystem first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add startup windows
2 participants