Fix srand "bug" for random vtrees #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RenatoGeh
force-pushed
the
rand
branch
2 times, most recently
from
8300451
to
5bd3800
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original SDD library includes an
srand(time(NULL))call at each random vtree construction. This causes a bug where, if multiple random vtrees are to be created in the space of less than a second, they all result in the same vtree, as subsequent calls tonew_random_vtreeset the same seed every time.This patchset addresses two issues. The first is a simple addition to
setup.cfg.setup.pyexplicitly calls forpython build_ext --inplaceto be run for building. By adding an additional entry tosetup.cfg, we guarantee every run ofpython buildcorresponds tobuild_ext --inplace. The second is recompiling the C libraries without the offending line to address the issue stated above.An additional change is adding an AUR package for Arch Linux users entry to the Installation section of the README.