Skip to content

Commit

Permalink
feat: use channel version for weave-trace
Browse files Browse the repository at this point in the history
  • Loading branch information
j7m4 committed Dec 18, 2024
1 parent df7073a commit bb357d5
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 22 deletions.
13 changes: 2 additions & 11 deletions cmd/wsm/download.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,12 +58,6 @@ func DownloadCmd() *cobra.Command {
fmt.Printf("Error fetching the latest operator-wandb controller tag: %v\n", err)
os.Exit(1)
}
// Fetch the latest tag for weave-trace
weaveTraceTag, err := getMostRecentTag("wandb/weave-trace")
if err != nil {
fmt.Printf("Error fetching the latest weave-trace tag: %v\n", err)
os.Exit(1)
}
fmt.Println("Downloading operator helm chart")
operatorImgs, _ := downloadChartImages(
helm.WandbHelmRepoURL,
Expand All @@ -87,11 +81,8 @@ func DownloadCmd() *cobra.Command {
}

// Enable weave-trace in the chart values
dlSpec.Values["weave-trace"] = map[string]interface{}{
"install": true,
"image": map[string]interface{}{
"tag": weaveTraceTag,
},
if dlWeaveTrace, ok := dlSpec.Values["weave-trace"]; ok {
dlWeaveTrace.(map[string]interface{})["install"] = true
}

fmt.Println("Downloading wandb helm chart")
Expand Down
13 changes: 2 additions & 11 deletions cmd/wsm/list.go
Original file line number Diff line number Diff line change
Expand Up @@ -124,12 +124,6 @@ func ListCmd() *cobra.Command {
p.Quit()
return
}
weaveTraceTag, err := getMostRecentTag("wandb/weave-trace")
if err != nil {
fmt.Printf("Error fetching the latest weave-trace tag: %v\n", err)
p.Quit()
return
}
operatorImgs, _ := downloadChartImages(
helm.WandbHelmRepoURL,
helm.WandbOperatorChart,
Expand All @@ -147,11 +141,8 @@ func ListCmd() *cobra.Command {
}

// Enable weave-trace in the chart values
spec.Values["weave-trace"] = map[string]interface{}{
"install": true,
"image": map[string]interface{}{
"tag": weaveTraceTag,
},
if weaveTrace, ok := spec.Values["weave-trace"]; ok {
weaveTrace.(map[string]interface{})["install"] = true
}

wandbImgs, _ := downloadChartImages(
Expand Down

0 comments on commit bb357d5

Please sign in to comment.