Skip to content

Commit

Permalink
fix(sdk): prevent issues due to bugs in earlier botocore versions
Browse files Browse the repository at this point in the history
  • Loading branch information
tonyyli-wandb committed Dec 4, 2024
1 parent d39d993 commit be457b2
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 4 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.unreleased.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,4 @@ Section headings should be at level 3 (e.g. `### Added`).
- Fix `ultralytics` reporting if there are no positive examples in a validation batch. (@Jamil in https://github.com/wandb/wandb/pull/8870)
- Debug printing for hyperband stopping algorithm printed one char per line (@temporaer in https://github.com/wandb/wandb/pull/8955)
- Include the missing `log_params` argument when calling lightgbm's `wandb_callback` function. (@i-aki-y https://github.com/wandb/wandb/pull/8943)
- Prevent errors from bugs in older versions of `botocore < 1.5.76` (@amusipatla-wandb, @tonyyli-wandb in https://github.com/wandb/wandb/pull/9015)
10 changes: 7 additions & 3 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,12 @@ wb = "wandb.cli.cli:cli"
[project.optional-dependencies]
kubeflow = ["kubernetes", "minio", "google-cloud-storage", "sh"]
gcp = ["google-cloud-storage"]
aws = ["boto3"]
aws = [
"boto3",
"botocore>=1.5.76",
# https://github.com/boto/botocore/pull/1107
# https://github.com/boto/botocore/pull/1230
]
azure = ["azure-identity", "azure-storage-blob"]
media = [
"numpy",
Expand All @@ -81,12 +86,11 @@ media = [
]
sweeps = ["sweeps>=0.2.0"]
launch = [
"wandb[aws]",
"awscli",
"azure-identity",
"azure-containerregistry",
"azure-storage-blob",
"boto3",
"botocore",
"chardet",
"google-auth",
"google-cloud-aiplatform",
Expand Down
6 changes: 5 additions & 1 deletion requirements_dev.txt
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,11 @@ responses
prometheus_client
google-cloud-aiplatform

boto3!=1.35.56
# See:
# - https://github.com/boto/botocore/pull/1107
# - https://github.com/boto/botocore/pull/1230
boto3
botocore>=1.5.76

.[perf]
.[launch]
Expand Down

0 comments on commit be457b2

Please sign in to comment.