Avoid secrets generation (#28)

Co-authored-by: Robert Ulbrich <[email protected]>
wandb · Aug 30, 2023 · 73fb61a · 73fb61a
1 parent 52271b6
commit 73fb61a
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 5 deletions.
diff --git a/charts/wandb/Chart.yaml b/charts/wandb/Chart.yaml
@@ -2,8 +2,8 @@ apiVersion: v2
 name: wandb
 description: A Helm chart for deploying W&B to Kubernetes
 type: application
-version: 0.2.0
-appVersion: "0.22.0"
+version: 0.2.1
+appVersion: "0.40.0"
 icon: https://wandb.ai/logo.svg
 maintainers:
   - name: wandb

diff --git a/charts/wandb/templates/deployment.yaml b/charts/wandb/templates/deployment.yaml
@@ -177,18 +177,20 @@ spec:
         {{- toYaml . | nindent 8 }}
       {{- end }}
       volumes:
-      {{- if or (not .Values.bucket) .Values.existingClaim }}
         - name: wandb-data
+      {{- if and (not .Values.bucket) .Values.existingClaim }}
           persistentVolumeClaim:
             claimName: {{ .Values.existingClaim | default (include "wandb.volumeClaim" .) }}
+      {{- else }}
+          emptyDir: {}
       {{- end }}
       {{- if .Values.customCACerts }}
         - name: wandb-ca-certs
           configMap:
             name: {{ include "wandb.fullname" . }}-ca-certs
       {{- end }}
 ---
-{{- if and (not .Values.bucket) (not .Values.existingClaim)  }}
+{{- if and (not .Values.bucket) .Values.existingClaim }}
 kind: PersistentVolumeClaim
 apiVersion: v1
 metadata:

diff --git a/charts/wandb/templates/secrets.yaml b/charts/wandb/templates/secrets.yaml
@@ -1,3 +1,4 @@
+{{- if .Values.createSecrets }}
 {{- $secretName := print (include "wandb.fullname" .) "-secrets" }}
 {{- $secret := (lookup "v1" "Secret" .Release.Namespace $secretName) }}
 apiVersion: v1
@@ -27,4 +28,5 @@ data:
 {{- end}}
 {{- if .Values.sso.clientSecret }}
   CLIENT_SECRET: {{ .Values.clientSecret | b64enc }}
-{{- end}}
+{{- end}}
+{{- end}}
diff --git a/charts/wandb/values.yaml b/charts/wandb/values.yaml
@@ -34,6 +34,9 @@ imagePullSecrets: []
 nameOverride: ""
 fullnameOverride: ""
 
+# Set to false in case you rely on externally created secrets e.g. when using Sealed Secrets
+createSecrets: true
+
 # dns hostAliases, generally only used in development
 hostAliases: []
 # Custom CA's to make SSL verification work for self signed certs