Try upgrading kind, use a PV when not connected to bucket, mysql fsGr…

…oup attempt

.github/workflows/lint-test.yaml

@@ -49,6 +49,8 @@ jobs:
 
       - name: Create kind cluster
         uses: helm/[email protected]
+        with:
+          version: v0.14.0
         if: steps.list-changed.outputs.changed == 'true'
 
       - name: Run chart-testing (install)

charts/wandb/templates/_helpers.tpl

@@ -23,6 +23,10 @@ If release name contains chart name it will be used as a full name.
 {{- end }}
 {{- end }}
 
+{{- define "wandb.volumeClaim" -}}
+{{- printf "%s-vol" (include "wandb.fullname" .) -}}
+{{- end }}
+
 {{- define "wandb.mysqlHost" -}}
 {{- printf "%s-mysql.%s.svc.cluster.local" (include "wandb.fullname" .) .Release.Namespace }}
 {{- end }}

charts/wandb/templates/deployment.yaml

@@ -114,7 +114,7 @@ spec:
             httpGet:
               path: /ready
               port: http
-            failureThreshold: 60
+            failureThreshold: 120
           {{- if not .Values.bucket }}
           volumeMounts:
             - name: wandb-data
@@ -134,8 +134,27 @@ spec:
       tolerations:
         {{- toYaml . | nindent 8 }}
       {{- end }}
-      {{- if not .Values.bucket }}
+      {{- if or (not .Values.bucket) .Values.existingClaim }}
       volumes:
         - name: wandb-data
-          emptyDir: {}
+          persistentVolumeClaim:
+            claimName: {{ .Values.existingClaim | default (include "wandb.volumeClaim" .) }}
       {{- end }}
+---
+{{- if and (not .Values.bucket) (not .Values.existingClaim)  }}
+kind: PersistentVolumeClaim
+apiVersion: v1
+metadata:
+  name: {{ include "wandb.volumeClaim" . }}
+  annotations:
+    "helm.sh/resource-policy": keep
+  labels:
+    {{- include "wandb.labels" . | nindent 4 }}
+    app.kubernetes.io/component: local
+spec:
+  accessModes:
+    - ReadWriteOnce
+  resources:
+    requests:
+      storage: 64Gi
+{{- end }}

charts/wandb/templates/mysql.yaml

@@ -29,7 +29,11 @@ spec:
         {{- toYaml . | nindent 8 }}
       {{- end }}
       serviceAccountName: {{ include "wandb.serviceAccountName" . }}
-      # TODO: security context
+      # TODO: flexible security context
+      securityContext:
+        runAsNonRoot: false
+        fsGroup: 27
+        fsGroupChangePolicy: "OnRootMismatch"
       initContainers:
       - name: "remove-lost-found"
         image: "busybox"

charts/wandb/values.yaml

@@ -20,6 +20,8 @@ bucketKmsKeyArn:
 smtpServer:
 # when setting up an ingress, set this to http://domain.com or https://domain.com
 host:
+# If you aren't connected to an external bucket and want to mount a custom claim for minio
+existingClaim:
 
 # set additional env variables
 extraEnv:

ct.yaml

@@ -5,4 +5,4 @@ chart-dirs:
   - charts
 chart-repos:
   - bitnami=https://charts.bitnami.com/bitnami
-helm-extra-args: --timeout 900s
+helm-extra-args: --timeout 600s