Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.4 nightly to tests #1051

Merged
merged 5 commits into from
Oct 21, 2024
Merged

Add PHP 8.4 nightly to tests #1051

merged 5 commits into from
Oct 21, 2024

Conversation

joanhey
Copy link
Contributor

@joanhey joanhey commented Aug 8, 2024

So we can find problems with time.

PHP 8.4 Timetable
https://wiki.php.net/todo/php84

WIP

So we can find problems with time.
@joanhey
Copy link
Contributor Author

joanhey commented Aug 8, 2024

Pest still don't work with PHP 8.4
pestphp/pest#1199

And more packages have problems with the explicit nullable type from PHP 8.4
composer/composer#12051

EDIT: Pest is working OK now 19/10/2024 pestphp/pest#1199

@joanhey
Copy link
Contributor Author

joanhey commented Oct 19, 2024

We still have deprecated messages from the Mockery 2 lib.
Mockery 1.6 is fixed for PHP 8.4, but we use v2.0.x that it isn't updated for the last 7 months.
We need to check the differences and change to v1.6. Or wait if they fix v2.0.x than it is a dev version.

@joanhey
Copy link
Contributor Author

joanhey commented Oct 19, 2024

We have another problem.
Workerman v4.1 also have deprecations:

  • explicit nullable type is only fixable with PHP 7.1 and now only require PHP 7.0
  • Constant E_STRICT is deprecated in /home/runner/work/AdapterMan/AdapterMan/vendor/workerman/workerman/Worker.php on line 518

@walkor
Copy link
Owner

walkor commented Oct 21, 2024

We have another problem. Workerman v4.1 also have deprecations:

  • explicit nullable type is only fixable with PHP 7.1 and now only require PHP 7.0
  • Constant E_STRICT is deprecated in /home/runner/work/AdapterMan/AdapterMan/vendor/workerman/workerman/Worker.php on line 518

Perhaps we should raise the minimum PHP version for Workerman v4.1 to 8.0.

@walkor walkor merged commit 4ede813 into walkor:master Oct 21, 2024
24 checks passed
@joanhey joanhey deleted the patch-1 branch October 21, 2024 09:25
@joanhey
Copy link
Contributor Author

joanhey commented Oct 23, 2024

Never for 4.1, but of course for v4.2
We need to change the composer json, and is ready.

walkor added a commit that referenced this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants