Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support multigroup #52

Draft
wants to merge 1 commit into
base: devel
Choose a base branch
from
Draft

support multigroup #52

wants to merge 1 commit into from

Conversation

LiNk-NY
Copy link
Contributor

@LiNk-NY LiNk-NY commented Jul 2, 2024

This is a draft PR for multigroup support

@LiNk-NY LiNk-NY force-pushed the feature/multigroup branch 2 times, most recently from 849ddb2 to b020437 Compare July 2, 2024 16:06
@LiNk-NY LiNk-NY force-pushed the feature/multigroup branch from b020437 to 495edec Compare August 19, 2024 20:32
@lwaldron
Copy link
Member

@shbrief don't forget this PR!

@lwaldron lwaldron requested a review from shbrief September 15, 2024 23:56
@shbrief
Copy link
Contributor

shbrief commented Sep 19, 2024

@LiNk-NY Is this pull request ready to be merged?

@LiNk-NY
Copy link
Contributor Author

LiNk-NY commented Sep 19, 2024

@shbrief Not yet, the plots have to be updated so that there are multiple panels of pairwise comparisons, IIRC.

@shbrief
Copy link
Contributor

shbrief commented Sep 19, 2024

@LiNk-NY Got it. Yeah, I was wondering how the plotting will be affected by multiple classes. :)

@lwaldron
Copy link
Member

@sdgamboa (and maybe @asyakhl ?) would you take a look at this PR and think about the plotting of multiple classes? I think it would just mean multiple pairwise classic LEfSe plots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants