CI: switch docker tests to dind #1966
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
due to Ubuntu 20.04 deprecation we cannot run Ubuntu 20 natively anymore
|
Why do you need docker in docker? We have quite a few things that we are running natively on hardware (not in the docker). |
|
current tests design is brilliant. binaries are built on a host (whatever it is, ubuntu 20 ... ubuntu 24 ...) and then delivered to old debian images. it only works if host is ubuntu 20. which we can achieve nowdays only by using containers because ubuntu 20 is removed from github actions |
|
@boosterKRD, what do you think of merging this ? it will fix at least several tests. the rest either will be addressed in some better way or maybe I'll have time to fix dind tests (I suspect they fail due to missing health checks, but I need more time to investigate) |
|
abandonig in favor of #1973 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
switch docker tests to docker in docker mode