Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ssr in dev mode again #195

Merged
merged 2 commits into from
Dec 1, 2023
Merged

fix: ssr in dev mode again #195

merged 2 commits into from
Dec 1, 2023

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Dec 1, 2023

I just noticed #189 didn't fix the issue fully. ChildrenContext is isolated.

Copy link

vercel bot commented Dec 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview Dec 1, 2023 5:19am

Copy link

codesandbox-ci bot commented Dec 1, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a8067d7:

Sandbox Source
Vanilla Typescript Configuration
React Configuration
React TypeScript Configuration

@dai-shi dai-shi marked this pull request as ready for review December 1, 2023 05:59
Copy link
Member Author

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, I'm getting to understand how things work. We need a big refactor in the near future.

@dai-shi dai-shi merged commit a6b5355 into main Dec 1, 2023
@dai-shi dai-shi deleted the fix-ssr-again branch December 1, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant